Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify common rust version correctly #134

Merged
merged 5 commits into from
May 31, 2023
Merged

specify common rust version correctly #134

merged 5 commits into from
May 31, 2023

Conversation

MarcoIeni
Copy link
Contributor

FYI, I think this is the Rust standard way to define a common Rust version
across a workspace.
Feel free to close this PR if it doesn't work well with your current workflow :)

@frol
Copy link
Collaborator

frol commented Mar 22, 2023

@miraclx I need to pick your brain to remind me if there is any problem with this approach of setting the version for the packages 🙏

I am happy to merge it if it works with the CI scripts we have!

@miraclx
Copy link
Contributor

miraclx commented Mar 23, 2023

Hard to say what effect this will have considering our dependency on cargo-workspaces, I'll extract a small example and run a test. But this already looks like a solution that significantly simplifies the intent.

@frol frol marked this pull request as ready for review May 31, 2023 07:39
@frol frol self-requested a review as a code owner May 31, 2023 07:39
@frol
Copy link
Collaborator

frol commented May 31, 2023

We don't seem to need cargo-workspaces in the first place. I will try using release-plz for release management in borsh-rs.

@frol frol merged commit 466b740 into near:master May 31, 2023
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants