-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make hashbrown
dependency optional, hashbrown
feature
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8759e7b
to
24f8918
Compare
frol
reviewed
Jun 20, 2023
7ec78a5
to
2919c24
Compare
24 tasks
hashbrown
dependency optional, external-hashcollections
featurehashbrown
dependency optional, hashbrown
feature
…l-hashcollections` feature
4672d0e
to
b2325e4
Compare
The following has probably to be done in addition to changes already included:
|
b91208a
to
0a2377b
Compare
frol
requested changes
Jun 21, 2023
7e33c4d
to
da9a3ba
Compare
…cted under a feature - the whole module with `BorshSchema` trait had to be put under conditional compilation due to it using `HashMap`/`HashSet` in its implementation
1a536a7
to
84b955d
Compare
6edac13
to
f4d5712
Compare
frol
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dj8yfo Well done! Thanks for the thorough work diving deep down into this rabbit hole
Just for future reference, this PR is a breaking change:
|
hashbrown
dependency optional, hashbrown
featurehashbrown
dependency optional, hashbrown
feature
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small fraction of #51
Resolves #45