Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl BorshSchema for HashSet #83

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Conversation

tzemanovic
Copy link
Contributor

closes #82

@tzemanovic tzemanovic marked this pull request as ready for review February 16, 2022 13:54
@frol
Copy link
Collaborator

frol commented Feb 16, 2022

As far as I remember, BorshSchema has never got to the usable state, and was considered experimental. Do you use it somewhere?

@tzemanovic
Copy link
Contributor Author

As far as I remember, BorshSchema has never got to the usable state, and was considered experimental. Do you use it somewhere?

Oh, I didn't know, thanks! I'm currently trying to use it to generate encoding docs for https://github.com/anoma/anoma. Do you have bandwidth for reviewing PRs for it? I found some other limitations and I'd be happy to fix them

@frol
Copy link
Collaborator

frol commented Feb 17, 2022

@austinabell @miraclx Is there any decision regarding borsh schema or rather I should ask if you have any plans revisiting it when dealing with the interfaces on near-sdk-rs side?

@austinabell
Copy link
Contributor

@austinabell @miraclx Is there any decision regarding borsh schema or rather I should ask if you have any plans revisiting it when dealing with the interfaces on near-sdk-rs side?

There are no guarantees that this format will be stable, but it's unclear at this time if or what the changes would need to be if any.

I don't have any issues with bringing this in that I can think of

@tzemanovic
Copy link
Contributor Author

alright, thanks! I'd also like to add schema to BTreeSet, BTreeMap and PhantomData. Can I add them here or do you prefer separate PRs?

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it does not hurt to have this merged

@frol frol merged commit 7325a0a into near:master Mar 18, 2022
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashSet BorshSchema implementation
3 participants