Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic hooks support #83

Merged
merged 8 commits into from Oct 11, 2023
Merged

feat: basic hooks support #83

merged 8 commits into from Oct 11, 2023

Conversation

andy-haynes
Copy link
Contributor

@andy-haynes andy-haynes commented Oct 10, 2023

This PR adds support for useEffect and useState by:

  • replacing the custom bundle with module imports 🎉
  • using Preact's options.diffed to dispatch render messages
  • calling the Preact hooks-injected options.diffed callback

This new approach ended up interfering with the styling in debug mode but this can be addressed separately.

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bos-web-engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 0:21am

@andy-haynes
Copy link
Contributor Author

@andy-haynes andy-haynes marked this pull request as ready for review October 11, 2023 20:39
@andy-haynes andy-haynes merged commit e6f7c80 into main Oct 11, 2023
2 checks passed
@andy-haynes andy-haynes deleted the feat/hooks branch October 11, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant