fix: Remove account_id validation from new_unvalidated()
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That function even explicitly says that it does no validation and that the validation is responsibility of the caller.
nikurt
changed the title
new_unvalidated()new_unvalidated()
frol
approved these changes
Nov 24, 2023
frol
added a commit
that referenced
this pull request
Nov 24, 2023
## 🤖 New release * `near-account-id`: 1.0.0-alpha.3 -> 1.0.0-alpha.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [1.0.0-alpha.4](v1.0.0-alpha.3...v1.0.0-alpha.4) - 2023-11-24 ### Fixed - Remove account_id validation from `new_unvalidated()` when `internal_unstable` feature is enabled (required by nearcore) ([#20](#20)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: Vlad Frolov <304265+frol@users.noreply.github.com> Co-authored-by: Vlad Frolov <304265+frol@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to near/nearcore
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That function even explicitly says that it does no validation and that the validation is responsibility of the caller.
The validation is a problem for executing
testnetreceipt9dTn32kX1gKFoP5YaeQKRs98QrcArbpYfB17ou3CNdMLin chunk5BNxaoUPWN7FaPNcUUPS17XXkM6zNh4bKmLAGNhhunN5at block height147314170