Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring JSONRpcProvider #703

Closed
willemneal opened this issue Oct 1, 2021 · 3 comments
Closed

Refactoring JSONRpcProvider #703

willemneal opened this issue Oct 1, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@willemneal
Copy link
Contributor

willemneal commented Oct 1, 2021

At its core JSONRpcProvider should be a stateless set of functions to make RPC requests. However, in its current form it caches access keys and parses error data immediately.

The access keys management should be handled by a key store, however, until that work is started this functionality will remain here.

As we have found with the runner it is advantageous to return the complete data from the RPC request in a class that provides parsing.

@Rishabhraghwendra18
Copy link
Contributor

Hi @willemneal . I think you may close this issue now

@willemneal
Copy link
Contributor Author

@Rishabhraghwendra18 The linked PR was only the first step of this issue.

@Rishabhraghwendra18
Copy link
Contributor

@willemneal I am sorry . I overlooked about it . I am new to this repo , the issue description is little bit unclear to me . May you explain me what changes/implementation I have to do regarding this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants