Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAJ-113-delete-hacks-related-to-error-types #910

Merged
merged 3 commits into from
Aug 10, 2022
Merged

NAJ-113-delete-hacks-related-to-error-types #910

merged 3 commits into from
Aug 10, 2022

Conversation

gutsyphilip
Copy link
Contributor

@gutsyphilip gutsyphilip commented Jul 29, 2022 •
edited by hcho112
Loading

Motivation

Delete https://github.com/near/near-api-js/blob/master/src/utils/rpc_errors.ts#L88 and other hacks related to Error handling and types as error types are now available on near-core.

Description

  • Remove getErrorTypeFromErrorMessage and every usage of it.
  • Pass error type directly with response.error.name
  • Remove related tests

Checklist

  • Read the contributing guidelines
  • Commit messages follow the conventional commits spec
  • Performed a self-review of the PR
  • Added automated tests
  • Manually tested the change

@hcho112 hcho112 force-pushed the NAJ-113-delete-hacks-related-to-error-types branch from b8ee649 to 53ffb5c Compare August 8, 2022 23:22
@hcho112 hcho112 removed the WIP label Aug 8, 2022
@hcho112
Copy link
Contributor

hcho112 commented Aug 8, 2022

I have rebased latest master and fixed broken test. Can I get some review on this PR?

@hcho112 hcho112 force-pushed the NAJ-113-delete-hacks-related-to-error-types branch from 53ffb5c to c399290 Compare August 9, 2022 23:57
@morgsmccauley morgsmccauley merged commit 5696829 into master Aug 10, 2022
@morgsmccauley morgsmccauley deleted the NAJ-113-delete-hacks-related-to-error-types branch August 10, 2022 01:21
@marcinbodnar marcinbodnar mentioned this pull request Sep 30, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho112 hcho112 hcho112 left review comments

@morgsmccauley morgsmccauley morgsmccauley approved these changes

@vgrichina vgrichina Awaiting requested review from vgrichina

@esaminu esaminu Awaiting requested review from esaminu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gutsyphilip @hcho112 @morgsmccauley