Closes #489: Compute Circulating Supply and expose via backend #504
Conversation
|
Your Render PR Server URL is https://near-explorer-frontend-pr-504.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-bvd0bo3lc6cgrt3fum30. |
| }; | ||
|
|
||
| // viewLockupState function taken from https://github.com/near/account-lookup/blob/master/script.js | ||
| const viewLockupState = async (contractId, blockHeight) => { |
There was a problem hiding this comment.
Just something that I noticed and was curious about; is it safe for viewLockupState() to retry indefinitely when it encounters any type of error, with no boundary to how many times it retries, and no error reporting if it has to retry many times to finish? Feels like this could permanently deadlock if fed e.g. a bad contractId? Same with while(true) loops on L126 & L152 of this file.
There was a problem hiding this comment.
@MaximusHaximus Thanks for pointing those out! This is a draft PR that we needed to collect the figures in the first place. Since then we have done more exploration of the space, and @telezhnaya will take it over from here solidifying the implementation and having graceful retry strategies.
@khorolets solution that needs to be finished #504
@khorolets solution that needs to be finished #504
|
Closing in favor of #636 |
@khorolets solution that needs to be finished #504 Decided not to apply changes to frontend
Closes #489
As for Acceptance Criteria
The value is re-computed every 1 hour instead of 2 because it takes ~20s to run.
returns 404, didn't change that