Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): Calculate circulating supply #636

Merged
merged 12 commits into from
May 26, 2021
Merged

feat(backend): Calculate circulating supply #636

merged 12 commits into from
May 26, 2021

Conversation

telezhnaya
Copy link
Contributor

Closes (in one day) #489

@telezhnaya telezhnaya self-assigned this May 21, 2021
@render
Copy link

render bot commented May 21, 2021

Your Render PR Server URL is https://near-explorer-frontend-with-indexer-pr.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c2jnu9j2v8panf9vk6c0.

@telezhnaya
Copy link
Contributor Author

It's too early to review that.
I feel that I will need to give links and ask questions soon, that's why I open it. I'll ping you directly when it's ready for review.

@frol frol marked this pull request as draft May 21, 2021 11:12
@frol frol mentioned this pull request May 21, 2021
Closed
@telezhnaya
feat(backend): Compute Circulating Supply and expose via backend
25c268a 
    @khorolets solution that needs to be finished
    #504
    Decided not to apply changes to frontend
frol
frol reviewed May 24, 2021
View reviewed changes
backend/src/db-utils.js Outdated Show resolved Hide resolved
backend/src/index.js Outdated Show resolved Hide resolved
@frol
Copy link
Collaborator

frol commented May 24, 2021 •
edited
Loading

Action item for @frol:

  • add wamp endpoint exposing the circulating supply value

@telezhnaya
Copy link
Contributor Author

Action item for @frol:

  • add wamp endpoint exposing the circulating supply value

I didn't want to commit anything from frontend, please check out the last commit, maybe it was done before
(I have no idea whether it's correct or not)

frol
frol reviewed May 24, 2021
View reviewed changes
backend/src/aggregations.js Outdated Show resolved Hide resolved
backend/src/aggregations.js Outdated Show resolved Hide resolved
backend/src/aggregations.js Outdated Show resolved Hide resolved
backend/src/db-utils.js Outdated Show resolved Hide resolved
@telezhnaya telezhnaya mentioned this pull request May 25, 2021
Closed
@telezhnaya telezhnaya mentioned this pull request May 25, 2021
Merged
@frol frol marked this pull request as ready for review May 25, 2021 20:13
@frol frol merged commit 84bba96 into master May 26, 2021
@frol frol deleted the olya/circulating branch May 26, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@shelegdmitriy shelegdmitriy Awaiting requested review from shelegdmitriy shelegdmitriy is a code owner

Assignees

@telezhnaya telezhnaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@telezhnaya @frol