Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: borsh version update #1075

Merged
merged 16 commits into from
Oct 9, 2023
Merged

chore: borsh version update #1075

merged 16 commits into from
Oct 9, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Aug 18, 2023

This pr is targeted to resolve the following sub-issue of borsh-rs #51:

  • test alpha release on near-sdk-rs and capture migration guide steps, create a draft PR (only merge after 1.0.0 release)

@dj8yfo dj8yfo mentioned this pull request Aug 18, 2023
Merged
@dj8yfo dj8yfo force-pushed the borsh_update branch 16 times, most recently from 50d86cb to f347c3e Compare August 25, 2023 18:23
@dj8yfo dj8yfo force-pushed the borsh_update branch 3 times, most recently from c01024e to f433590 Compare August 25, 2023 20:18
frol
frol reviewed Aug 26, 2023
View reviewed changes
near-sdk/Cargo.toml Outdated Show resolved Hide resolved
near-sdk/src/store/index_map.rs Show resolved Hide resolved
near-sdk/src/store/tree_map/iter.rs Outdated Show resolved Hide resolved
examples/adder/Cargo.toml Outdated Show resolved Hide resolved
@dj8yfo dj8yfo force-pushed the borsh_update branch 4 times, most recently from 0849ecc to f96ebea Compare August 29, 2023 18:11
@dj8yfo dj8yfo force-pushed the borsh_update branch 4 times, most recently from 42759d9 to fe5f641 Compare September 5, 2023 18:43
frol
frol reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

examples/mission-control/src/agent.rs Outdated Show resolved Hide resolved
near-sdk/Cargo.toml Outdated Show resolved Hide resolved
@frol frol mentioned this pull request Sep 15, 2023
Closed
frol
frol approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dj8yfo This change looks great to me!

@frol frol mentioned this pull request Oct 6, 2023
Merged
frol
frol reviewed Oct 8, 2023
View reviewed changes
examples/adder/Cargo.toml Outdated Show resolved Hide resolved
@dj8yfo dj8yfo marked this pull request as ready for review October 9, 2023 08:51
@dj8yfo dj8yfo requested a review from frol October 9, 2023 09:39
frol
frol approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@frol frol merged commit 9b27b37 into near:master Oct 9, 2023
14 checks passed
@frol frol mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dj8yfo @frol