Skip to content

Commit

Permalink
chore: remove per component code owners (#6516)
Browse files Browse the repository at this point in the history
* chore: remove per compponent code owners

* Update CODEOWNERS

Co-authored-by: mm-near <91919554+mm-near@users.noreply.github.com>
  • Loading branch information
bowenwang1996 and mm-near committed Apr 1, 2022
1 parent 7ffea74 commit a1ce804
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 35 deletions.
34 changes: 1 addition & 33 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,36 +1,4 @@
# CODEOWNERS: https://help.github.com/articles/about-codeowners/

/chain/ @bowenwang1996 @mzhangmzz @mm-near
/chain/client/src/view_client.rs @khorolets @rtsai123
/chain/client-primitives/ @mina86 @nikurt
/chain/network/ @mm-near @bowenwang1996
/chain/network-primitives/ @mm-near
/chain/jsonrpc/ @mina86 @nikurt
/chain/jsonrpc-primitives/ @mina86 @nikurt
/chain/indexer/ @khorolets @mm-near
/chain/indexer-primitives/ @khorolets @mm-near
/chain/rosetta-rpc/ @frol @mina86
/utils @mm-near

/runtime/ @bowenwang1996 @EgorKulikov @mzhangmzz @mm-near
/runtime/runtime-params-estimator/ @matklad @jakmeier
/runtime/near-test-contracts/ @matklad @Longarithm
/runtime/near-vm-runner-standalone/ @matklad @nagisa
/runtime/near-vm-runner/ @matklad @nagisa

/genesis-tools/ @nikurt
/tools/indexer/ @khorolets
/tools/themis/ @miraclx

/core/ @bowenwang1996 @matklad @mm-near
/core/store/src/trie @mzhangmzz @longarithm
/neard/ @bowenwang1996 @mm-near
/nearcore/ @bowenwang1996 @mm-near
/test-utils/state-viewer @nikurt
/test-utils/runtime-tester @posvyatokum @matklad

. @near/nearcore-codeowners
/.buildkite/ @rtsai123 @mhalambek
/scripts/ @rtsai123 @mhalambek @mina86 @nikurt

/docs/ @bowenwang1996 @matklad @mm-near
/pytest/ @mm-near @mina86
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ The `test plan` should describe in detail what tests are presented, and what cas
### After the PR is submitted

1. We have a CI process configured to run all the sanity tests on each PR. If the CI fails on your PR, you need to fix it before it will be reviewed.
2. Once the CI passes, you should expect the first feedback to appear within 48 hours.
The reviewers will first review your tests, and make sure that they can convince themselves the test coverage is adequate before they even look into the change, so make sure you tested all the corner cases.
2. Once the CI passes, you should expect the first feedback to appear within one business day.
One code owner (chosen in a round robin order for the codeowner list) will first review your pull request.
They may re-assign the pull request to another person if they feel that they don't have sufficient expertise to review the pull request.
The reviewers will review your tests, and make sure that they can convince themselves the test coverage is adequate before they even look into the change, so make sure you tested all the corner cases.
If you would like to request review from a specific review, feel free to do so [through the github UI](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review).
3. Once you address all the comments, and your PR is accepted, we will take care of merging it.
4. If your PR introduces a new protocol feature, please document it in [CHANGELOG.md](CHANGELOG.md) under `unreleased`.
Expand Down

0 comments on commit a1ce804

Please sign in to comment.