chore: remove per component code owners #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
changed the title
mm-near
approved these changes
Apr 1, 2022
matklad
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the nearcore code review process is substandard. When a PR is submitted, code owners’ reviews are automatically requested. Given that some components have a few code owners, often a PR automatically requests review from many people. At the same time, a PR needs approvals from at least one code owner of every component. As a result, the code review process may take several days and sometimes people ignore those review requests thinking that other code owners would review them instead.
After some discussion with @mm-near and @matklad, we decide to experiment with the following solution: there will be a single team of codeowners and once a pull request is submitted, one of the codeowners' review will be requested. The chosen codeowner can re-assign to another person for review if they feel they don't have sufficient expertise to review the PR. This should increase the turnaround time for a PR to get merged. Let's see how it goes and we can adjust the process as we go.