Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actix-web dependencies #4240

Closed
frol opened this issue Apr 19, 2021 · 1 comment · Fixed by #4268
Closed

Update actix-web dependencies #4240

frol opened this issue Apr 19, 2021 · 1 comment · Fixed by #4268
Assignees
Labels
C-housekeeping Category: Refactoring, cleanups, code quality P-low Priority: low

Comments

@frol
Copy link
Collaborator

frol commented Apr 19, 2021

We need to update actix-web dependencies to the latest beta releases and migrate from actix-web::client to awc, it seems actix-web::client has been dropped in the recent actix-web releases.

This will unblock us so we can address other issues with jsonrpc-client.

Hint: we need to update the dependencies in all the nearcore crates, and use cargo deny --all-features check bans to check sanity that we don't have duplicate dependencies (update deny.toml if necessary). Some actix dependencies are patched, so let me know if you bump into some actix dependency that needs to be bumped on my fork.

@frol frol added C-housekeeping Category: Refactoring, cleanups, code quality P-low Priority: low labels Apr 19, 2021
@miraclx
Copy link
Contributor

miraclx commented Apr 19, 2021

Acknowledged! I'm on it.

near-bulldozer bot pushed a commit that referenced this issue May 5, 2021
Fixes #4240

- Update `actix-web` to latest beta `v4.0.0-beta.6`
- Migrate to using `awc` directly instead of previously re-exported `actix_web::client`
- Pulled upstream updates for [`near/actix-extras`](https://github.com/near/actix-extras) and updated `actix-web` dependency on all crates (actix/actix-extras@master...near:actix-web-4-beta.6)
  - Reimplemented cookie adapter (near/actix-extras@f3e6f09) that was removed from `actix-http` (actix/actix-web#2065)
- Forked [`paperclip`](https://github.com/near/paperclip) and updated `actix-web`, adding and defaulting to the `actix4` feature flag (near/paperclip@b9589c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality P-low Priority: low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants