refactor: Upgrade actix-web #4268
Conversation
There was a problem hiding this comment.
Great! We only need to make sure all the existing tests pass. Let's run nayduck: https://github.com/near/nearcore/blob/master/nightly/nayduck.py
Just sign up on the nayduck website and run python nightly/nayduck.py (and post the link to the build)
frol
requested review from
bowenwang1996,
chefsale,
evgenykuzyakov,
khorolets,
MaksymZavershynskyi and
SkidanovAlex
as code owners
There was a problem hiding this comment.
@frol why do we want to upgrade to some beta version? Is it better to wait for a stable release?
There was a problem hiding this comment.
LGTM :) yes, only not sure if we want to use beta? Agree with @bowenwang1996.
|
NayDuck link: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1572 |
|
@bowenwang1996 we are already on actix betas (that was to migrate to tokio 1.x). This upgrade needed to acquire some new configuration options of awc (actix client), such as configurable size of payload to fix jsonrpc-client, and potentially resolve telemetry issue. |
Fixes #4240
actix-webto latest betav4.0.0-beta.6awcdirectly instead of previously re-exportedactix_web::clientnear/actix-extrasand updatedactix-webdependency on all crates (actix/actix-extras@master...near:actix-web-4-beta.6)actix-http(remove cookie support from -http actix/actix-web#2065)paperclipand updatedactix-web, adding and defaulting to theactix4feature flag (near/paperclip@b9589c6)