Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(resharding) - test node restart after resharding #10541

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Jan 31, 2024

Test that resharding is correctly resumed (not restarted) if the node is restared after resharding was finished.

cc @posvyatokum @marcelo-gonzalez
I wonder what is the difference between this setup and the mocknet setup where it failed?

@wacban wacban requested a review from a team as a code owner January 31, 2024 15:58
@wacban
Copy link
Contributor Author

wacban commented Jan 31, 2024

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c11ad4a) 71.87% compared to head (8290de1) 71.89%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10541      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.01%     
==========================================
  Files         723      723              
  Lines      146964   146964              
  Branches   146964   146964              
==========================================
+ Hits       105631   105659      +28     
+ Misses      36468    36446      -22     
+ Partials     4865     4859       -6     
Flag Coverage Δ
backward-compatibility 0.08% <ø> (ø)
db-migration 0.08% <ø> (ø)
genesis-check 1.25% <ø> (ø)
integration-tests 36.95% <ø> (+0.09%) ⬆️
linux 71.07% <ø> (+0.02%) ⬆️
linux-nightly 71.28% <ø> (+0.03%) ⬆️
macos 54.76% <ø> (-0.22%) ⬇️
pytests 1.47% <ø> (ø)
sanity-checks 1.26% <ø> (ø)
unittests 67.83% <ø> (+<0.01%) ⬆️
upgradability 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shreyan-gupta shreyan-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for merging the test but no idea what the difference between this test and mocknet setup is :(

@wacban wacban added this pull request to the merge queue Jan 31, 2024
Merged via the queue into master with commit e7fc5a6 Jan 31, 2024
28 checks passed
@wacban wacban deleted the waclaw-resharding-restart branch January 31, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants