Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] TestEnvBuilder takes genesis_config as input #10594

Merged
merged 2 commits into from Feb 9, 2024

Conversation

shreyan-gupta
Copy link
Contributor

This schema makes way more sense for the TestEnv::builder() to take the genesis_config instead of chain_genesis.

Note that real_epoch_manager requires a genesis_config which in a future PR we can directly supply from the test environment builder.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (748448a) 71.98% compared to head (527d9ad) 72.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10594      +/-   ##
==========================================
+ Coverage   71.98%   72.02%   +0.03%     
==========================================
  Files         724      725       +1     
  Lines      147208   147196      -12     
  Branches   147208   147196      -12     
==========================================
+ Hits       105975   106011      +36     
+ Misses      36375    36331      -44     
+ Partials     4858     4854       -4     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 37.06% <52.38%> (+<0.01%) ⬆️
linux 71.07% <100.00%> (+0.04%) ⬆️
linux-nightly 71.44% <100.00%> (+0.01%) ⬆️
macos 55.01% <100.00%> (+0.02%) ⬆️
pytests 1.46% <0.00%> (-0.01%) ⬇️
sanity-checks 1.26% <0.00%> (-0.01%) ⬇️
unittests 67.92% <100.00%> (+0.01%) ⬆️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into master with commit 8c34e92 Feb 9, 2024
29 of 30 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/test/genesis_config branch February 9, 2024 13:59
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2024
Buildup PRs

#10590
#10591
#10594

Next PR I'll try using the real epoch manager as default and let's see
what happens...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants