Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] ChainGenesis::new from genesis_config instead of genesis #10591

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

shreyan-gupta
Copy link
Contributor

ChainGenesis constructor currently takes the whole genesis as input. We might as well just work with the genesis config.

Further down the line, this would be helpful to change the test environment to store just the genesis_config instead of chain_genesis.

Future plans to only use real epoch manager would benefit as real epoch manager takes genesis_config as input.

@shreyan-gupta shreyan-gupta marked this pull request as ready for review February 8, 2024 21:55
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner February 8, 2024 21:55
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4b815be) 72.02% compared to head (124563f) 71.99%.

Files Patch % Lines
integration-tests/src/genesis_helpers.rs 0.00% 2 Missing ⚠️
tools/speedy_sync/src/main.rs 0.00% 1 Missing ⚠️
tools/state-viewer/src/state_parts.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10591      +/-   ##
==========================================
- Coverage   72.02%   71.99%   -0.03%     
==========================================
  Files         724      724              
  Lines      147205   147205              
  Branches   147205   147205              
==========================================
- Hits       106022   105985      -37     
- Misses      36329    36366      +37     
  Partials     4854     4854              
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <0.00%> (ø)
integration-tests 37.11% <57.14%> (-0.02%) ⬇️
linux 71.03% <80.95%> (+<0.01%) ⬆️
linux-nightly 71.45% <80.95%> (-0.05%) ⬇️
macos 54.95% <89.47%> (+0.20%) ⬆️
pytests 1.46% <0.00%> (ø)
sanity-checks 1.26% <0.00%> (ø)
unittests 67.89% <89.47%> (-0.02%) ⬇️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit 3a6697f Feb 9, 2024
27 of 28 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/test/chain_genesis_new branch February 9, 2024 09:04
github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2024
Buildup PRs

#10590
#10591
#10594

Next PR I'll try using the real epoch manager as default and let's see
what happens...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants