feat(mocknet): use neard fork-network to set up mocknet nodes #11034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11034 +/- ##
==========================================
- Coverage 71.33% 71.31% -0.02%
==========================================
Files 760 758 -2
Lines 152343 152494 +151
Branches 152343 152494 +151
==========================================
+ Hits 108669 108750 +81
- Misses 39204 39307 +103
+ Partials 4470 4437 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
posvyatokum
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support in neard_runner.py for nodes whose initial state will be created via
neard fork-networkinstead of by parsing a big records json file. This will result in much faster startup times.It will be implemented by detecting what files exist in the
~/.near/setupdirectory. If they contain justgenesis.jsonandrecords.json, we assume we're running an old version of node setup, and if it looks like it contains a full NEAR home directory, we will assume it's prepared to be used withneard fork-network. The only thing that changes formirror.pyis that agenesis_timeargument will be required in this case in order to get a consistent network fromneard fork-network set-validatorsacross all the nodes