Switch default log level for mocknet to INFO #11353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
requested review from
akhi3030,
VanBarbascu,
marcelo-gonzalez and
robin-near
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11353 +/- ##
=======================================
Coverage 71.24% 71.24%
=======================================
Files 784 784
Lines 157833 157833
Branches 157833 157833
=======================================
+ Hits 112452 112453 +1
+ Misses 40535 40534 -1
Partials 4846 4846
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robin-near
approved these changes
May 20, 2024
akhi3030
approved these changes
May 21, 2024
marcelo-gonzalez
approved these changes
May 21, 2024
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
May 23, 2024
Before this change, the default log level is DEBUG, which generate just too many logs. With this change the new log levels are as follows: - WARN: actix_web,mio,tokio_util,actix_server,actix_http - DEBUG: client, chain - INFO: everything else We use the `log_config.json` file to set the level as described [here](https://near.github.io/nearcore/practices/workflows/otel_traces.html#configuration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the default log level is DEBUG, which generate just too many logs.
With this change the new log levels are as follows:
We use the
log_config.jsonfile to set the level as described here.