Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: instrument outcome proof computation #11778

Merged

Conversation

bowenwang1996
Copy link
Collaborator

Adding instrumentation on outcome proof computation, which may take a non-negligible amount of time if there are thousands of outcomes.

@bowenwang1996 bowenwang1996 requested a review from a team as a code owner July 12, 2024 17:28
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (9b0c147) to head (6f321bd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11778   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files         796      796           
  Lines      162924   162917    -7     
  Branches   162924   162917    -7     
=======================================
- Hits       116939   116934    -5     
  Misses      40932    40932           
+ Partials     5053     5051    -2     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (+<0.01%) ⬆️
db-migration 0.23% <0.00%> (+<0.01%) ⬆️
genesis-check 1.35% <0.00%> (+<0.01%) ⬆️
integration-tests 37.91% <100.00%> (-0.01%) ⬇️
linux 71.30% <100.00%> (-0.01%) ⬇️
linux-nightly 71.36% <100.00%> (-0.02%) ⬇️
macos 54.55% <100.00%> (-0.01%) ⬇️
pytests 1.58% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.38% <0.00%> (+<0.01%) ⬆️
unittests 66.22% <100.00%> (+<0.01%) ⬆️
upgradability 0.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenwang1996
Copy link
Collaborator Author

bowenwang1996 commented Jul 16, 2024

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jul 16, 2024

@bowenwang1996 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 1
@wacban 1

The average score is 1

@bowenwang1996 check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowenwang1996 bowenwang1996 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into near:master with commit 54bfccb Jul 16, 2024
29 of 30 checks passed
@bowenwang1996 bowenwang1996 deleted the instrument-compute-outcomes-proofs branch July 16, 2024 16:53
@race-of-sloths
Copy link

🔄 The PR has been merged.

Important

This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️

@frol
Copy link
Collaborator

frol commented Jul 16, 2024

@wacban @tayfunelmas Please, score this PR with @race-of-sloths score [0, 1, 2, 3, 5, 8, 13] command (see scoring criteria)

@near near deleted a comment from race-of-sloths Jul 16, 2024
@wacban
Copy link
Contributor

wacban commented Jul 17, 2024

@race-of-sloths score 1

@race-of-sloths
Copy link

🌟 Score recorded!

@wacban, thank you for scoring this pull request in the Race of Sloths!

@frol
Copy link
Collaborator

frol commented Jul 17, 2024

@race-of-sloths score 1

(I have to score as my previous message was incorrectly recognized as scoring 0 points)

@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 1!
You have received 20 (10 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @bowenwang1996! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants