feat: Simple randomness beacon #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkidanovAlex
requested review from
bowenwang1996,
evgenykuzyakov and
MaksymZavershynskyi
as code owners
SkidanovAlex
force-pushed
the
biasable_rnd
branch
4 times, most recently
from
43ff1c1
to
904bbcf
Compare
|
Yes, we need to make sure the staking transaction always contains ED25519 that is convertable to restretto. Will add. |
SkidanovAlex
force-pushed
the
biasable_rnd
branch
from
904bbcf
to
3f7391b
Compare
bowenwang1996
approved these changes
Feb 22, 2020
MaksymZavershynskyi
suggested changes
Feb 22, 2020
SkidanovAlex
force-pushed
the
biasable_rnd
branch
from
bd619ae
to
a40d2c2
Compare
|
|
||
| // Data to confirm the correctness of randomness beacon output | ||
| pub vrf_value: near_crypto::vrf::Value, | ||
| pub vrf_proof: near_crypto::vrf::Proof, |
There was a problem hiding this comment.
Why there are two fields vrf_value and random_value in different places?
There was a problem hiding this comment.
The logic is the following: with this randomness beacon the random_value = hash(vrf_value).
However, once we switch to the new randomness beacon, that will change to random_value = new_beacon(hash(vrf_value)). In other words, vrf_value will always stay the output of the VRF by the current block producer, while the way the random_value is computed can change.
This implements a simple biasable randomness beacon. The work on the unbiasable randomness beacon is here: https://github.com/nearprotocol/nearcore/commits/rnd_integration The biasable randomness beacon in this commit just uses the VRF created by the current block proposer, thus it has 1 bit of influence (the block proposer can choose not to create a block), which is sufficient for the block producers rotation, but should be used with caution for other use cases. Test plan --------- No new tests added as part of the change.
SkidanovAlex
force-pushed
the
biasable_rnd
branch
from
a40d2c2
to
48ab2c2
Compare
MaksymZavershynskyi
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a simple biasable randomness beacon. The work on the
unbiasable randomness beacon is here:
https://github.com/nearprotocol/nearcore/commits/rnd_integration
The biasable randomness beacon in this commit just uses the VRF created
by the current block proposer, thus it has 1 bit of influence (the block
proposer can choose not to create a block), which is sufficient for the
block producers rotation, but should be used with caution for other use
cases.
Test plan
No new tests added as part of the change.