fix: change default behavior of neard testnet #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of neard testnet changed
bowenwang1996
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
I am not entirely sure whether this is intended. I think we wanted the default value to be 4, but I'll approve to unblock
It is intended #4569 (comment). Thanks for fixing this!
Merged
mzhangmzz
added a commit
that referenced
this pull request
Aug 20, 2021
fixes #4464 fixes #4569 Test plan: verify the genesis config generated is the same as 1.19.2 ``` $ nearcore-1 git:(ebc1e0a) diff /Users/minzhang/.near-1.19.2/test0/genesis.json /Users/minzhang/.near-now/test0/genesis.json 2,4c2,4 < "protocol_version": 45, < "genesis_time": "2021-08-18T15:45:26.235826Z", < "chain_id": "test-chain-WLJhS", --- > "protocol_version": 47, > "genesis_time": "2021-08-18T15:40:31.252129Z", > "chain_id": "test-chain-b25OT", 156a157,159 > "ripemd160_base": 853675086, > "ripemd160_block": 680107584, > "ecrecover_base": 3365369625000, 205a209 > "max_transaction_size": 4194304, 242a247 > "simple_nightshade_shard_config": null, 251c256,257 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 272c278,279 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 293c300,301 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1"```
mzhangmzz
added a commit
that referenced
this pull request
Aug 20, 2021
fixes #4464 fixes #4569 Test plan: verify the genesis config generated is the same as 1.19.2 ``` $ nearcore-1 git:(ebc1e0a) diff /Users/minzhang/.near-1.19.2/test0/genesis.json /Users/minzhang/.near-now/test0/genesis.json 2,4c2,4 < "protocol_version": 45, < "genesis_time": "2021-08-18T15:45:26.235826Z", < "chain_id": "test-chain-WLJhS", --- > "protocol_version": 47, > "genesis_time": "2021-08-18T15:40:31.252129Z", > "chain_id": "test-chain-b25OT", 156a157,159 > "ripemd160_base": 853675086, > "ripemd160_block": 680107584, > "ecrecover_base": 3365369625000, 205a209 > "max_transaction_size": 4194304, 242a247 > "simple_nightshade_shard_config": null, 251c256,257 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 272c278,279 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 293c300,301 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1"```
mzhangmzz
added a commit
that referenced
this pull request
Aug 20, 2021
fixes #4464 fixes #4569 Test plan: verify the genesis config generated is the same as 1.19.2 ``` $ nearcore-1 git:(ebc1e0a) diff /Users/minzhang/.near-1.19.2/test0/genesis.json /Users/minzhang/.near-now/test0/genesis.json 2,4c2,4 < "protocol_version": 45, < "genesis_time": "2021-08-18T15:45:26.235826Z", < "chain_id": "test-chain-WLJhS", --- > "protocol_version": 47, > "genesis_time": "2021-08-18T15:40:31.252129Z", > "chain_id": "test-chain-b25OT", 156a157,159 > "ripemd160_base": 853675086, > "ripemd160_block": 680107584, > "ecrecover_base": 3365369625000, 205a209 > "max_transaction_size": 4194304, 242a247 > "simple_nightshade_shard_config": null, 251c256,257 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 272c278,279 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 293c300,301 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1"```
mzhangmzz
added a commit
that referenced
this pull request
Sep 7, 2021
fixes #4464 fixes #4569 Test plan: verify the genesis config generated is the same as 1.19.2 ``` $ nearcore-1 git:(ebc1e0a) diff /Users/minzhang/.near-1.19.2/test0/genesis.json /Users/minzhang/.near-now/test0/genesis.json 2,4c2,4 < "protocol_version": 45, < "genesis_time": "2021-08-18T15:45:26.235826Z", < "chain_id": "test-chain-WLJhS", --- > "protocol_version": 47, > "genesis_time": "2021-08-18T15:40:31.252129Z", > "chain_id": "test-chain-b25OT", 156a157,159 > "ripemd160_base": 853675086, > "ripemd160_block": 680107584, > "ecrecover_base": 3365369625000, 205a209 > "max_transaction_size": 4194304, 242a247 > "simple_nightshade_shard_config": null, 251c256,257 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 272c278,279 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1" 293c300,301 < "storage_usage": 0 --- > "storage_usage": 0, > "version": "V1"```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4464
fixes #4569
Test plan: verify the genesis config generated is the same as 1.19.2