refactor: reword error msg for reporting transactions failing for requiring full-access keys #4794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4746, hopes to be clearer with the error message when using a non-full-access key for a transaction that either has multiple actions or is not a function-call action.
Before:
After:
Would've been nice if we could resolve this issue with a message like
Cannot send money without a full access key
but that would require the error variant to encode a cause. But we can at least ease understanding what went wrong with a better error message that properly describes why this variant would be returned.