chore(near-primitives): document why FunctionCallPermission::receiver_id != AccountId #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
requested review from
bowenwang1996,
frol and
MaksymZavershynskyi
as code owners
frol
approved these changes
Sep 1, 2021
|
@miraclx Thanks for landing these code quality improvements! |
bowenwang1996
approved these changes
Sep 1, 2021
matklad
approved these changes
Sep 2, 2021
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4739: documents why the
receiver_idfield inFunctionCallPermissionisn't anAccountIddespite recently refactoring the whole workspace to using strictAccountId-s.See #4621 (comment) for more context