-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn user if the state is probably corrupted (one of previous migrations was interrupted) #6279
Conversation
I've just made #6282 which doesn't write anything to DB, but makes a persistent checkpoint to disk. This way we can not only detect if DB is probably corrupted, but can also recover without re-downloading a snapshot. |
Why don't use transactions to make migrations atomic? |
It seems a single migration can be too big (the whole storage update) and putting it into a single transaction can lead to issues. That's my guess seeing the implementation. Anyways @nikurt 's change uses checkpoints to guarantee migrations being transactional so I guess this change is not needed anymore. |
This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks. |
let's abandon this PR for now - in favor of @nikurt approach with checkpoints. |
Config changes:
State changes: