core: views: prefer base64_format to manual base64 conversions #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than declaring a field String and having all the users do base64 conversion manually, declare it Vec<u8> with base64_format serialisation scheme. This way, only the serialisation code needs to worry how the data looks on the wire. This also means that users reading the data don’t need to worry about decoding errors. Fixes: near#7232
nagisa
approved these changes
Aug 1, 2022
frol
added a commit
that referenced
this pull request
Sep 23, 2022
It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore. Tagged: https://github.com/near/nearcore/releases/tag/crates-0.15.0 Notable changes: - #6924 - #6941 - (BREAKING CHANGE) #7308 Check here for a full changelog: crates-0.14.0...crates-0.15.0
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2022
It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore. Tagged: https://github.com/near/nearcore/releases/tag/crates-0.15.0 Notable changes: - #6924 - #6941 - (BREAKING CHANGE) #7308 Check here for a full changelog: crates-0.14.0...crates-0.15.0
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore. Tagged: https://github.com/near/nearcore/releases/tag/crates-0.15.0 Notable changes: - #6924 - #6941 - (BREAKING CHANGE) #7308 Check here for a full changelog: crates-0.14.0...crates-0.15.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than declaring a field String and having all the users do
base64 conversion manually, declare it Vec with base64_format
serialisation scheme. This way, only the serialisation code needs to
worry how the data looks on the wire. This also means that users
reading the data don’t need to worry about decoding errors.
Fixes: #7232