Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move flat storage metrics to a separate module #8752

Merged
merged 2 commits into from
Mar 20, 2023
Merged

refactor: move flat storage metrics to a separate module #8752

merged 2 commits into from
Mar 20, 2023

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Mar 17, 2023 •
edited
Loading

Part of #8577.

This PR moves flat storage metrics structs to a separate module under near_store::flat.

Benefits of this change:

  • separation of concerns
  • metrics setup involves quite some boilerplate code which pollutes business logic and increases file size, hence moving that to a separate file

@pugachAG pugachAG requested a review from a team as a code owner March 17, 2023 20:52
@pugachAG pugachAG force-pushed the flat-storage-refactor-metrics branch from 68547d5 to cfcf24b Compare March 17, 2023 20:53
@pugachAG pugachAG mentioned this pull request Mar 17, 2023
Closed
8 tasks
@pugachAG pugachAG added the A-storage Area: storage and databases label Mar 17, 2023
jakmeier
jakmeier approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jakmeier jakmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@near-bulldozer near-bulldozer bot merged commit 75763ee into near:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakmeier jakmeier jakmeier approved these changes

@Longarithm Longarithm Awaiting requested review from Longarithm

Assignees
No one assigned
Labels
A-storage Area: storage and databases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugachAG @jakmeier