Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement inlining for small values in flat storage #9029

Merged
merged 3 commits into from
May 8, 2023
Merged

feat: implement inlining for small values in flat storage #9029

merged 3 commits into from
May 8, 2023

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented May 8, 2023 •
edited

Part of #8243.

This PR consists of 2 parts:

@pugachAG pugachAG requested review from Longarithm and nikurt May 8, 2023 11:52
@pugachAG pugachAG marked this pull request as ready for review May 8, 2023 11:52
@pugachAG pugachAG requested a review from a team as a code owner May 8, 2023 11:52
Longarithm
Longarithm approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for adding split code changes in the description!
Have you tested it on some real node with flat storage?

@pugachAG
Copy link
Contributor Author

pugachAG commented May 8, 2023

@Longarithm I've manually tested it in the following way:

  1. take FlatStateChanges column data from mainnet
  2. confirm that FlatStateChanges::try_from_slice returns Err for that data
  3. run migrate_36_to_37
  4. check that all FlatStateChanges entries contains the same number of entries and those can be deserialised.

@pugachAG pugachAG added A-storage Area: storage and databases S-automerge labels May 8, 2023
@near-bulldozer near-bulldozer bot merged commit 4244d1f into near:master May 8, 2023
nikurt pushed a commit that referenced this pull request May 10, 2023
@pugachAG @nikurt
feat: implement inlining for small values in flat storage (#9029)
ff8650f 
Part of #8243.

This PR consists of 2 parts:
* 08ecc51: un-revert #9005, see #8988 for the detailed description of the changes.
* 3d29347: db migration for flat state delta changes to avoid backward compatibility issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Longarithm Longarithm Longarithm approved these changes

@nikurt nikurt nikurt approved these changes

Assignees
No one assigned
Labels
A-storage Area: storage and databases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pugachAG @Longarithm @nikurt