Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: use correct type #9696

Merged
merged 1 commit into from
Oct 17, 2023
Merged

nit: use correct type #9696

merged 1 commit into from
Oct 17, 2023

Conversation

akhi3030
Copy link
Collaborator

Even though the types are just aliases, still use correct type definitions.

@akhi3030 akhi3030 requested a review from a team as a code owner October 17, 2023 12:23
@akhi3030 akhi3030 requested a review from nikurt October 17, 2023 12:23
Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about types NumShards and NumBlocks :)

@akhi3030 akhi3030 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into near:master with commit 2f16f45 Oct 17, 2023
9 checks passed
@akhi3030 akhi3030 deleted the use-correct-type branch October 17, 2023 13:10
nikurt pushed a commit that referenced this pull request Oct 18, 2023
Even though the types are just aliases, still use correct type
definitions.
nikurt pushed a commit that referenced this pull request Oct 20, 2023
Even though the types are just aliases, still use correct type
definitions.
nikurt pushed a commit that referenced this pull request Oct 20, 2023
Even though the types are just aliases, still use correct type
definitions.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants