Compile Keccak benchmark from Rust #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
build_benchmarks
branch
from
e72d1be
to
b7e6f16
Compare
aborg-dev
changed the title
mooori
reviewed
Mar 4, 2024
nagisa
reviewed
Mar 4, 2024
aborg-dev
force-pushed
the
build_benchmarks
branch
from
e23fd2b
to
9c51c74
Compare
aborg-dev
force-pushed
the
build_benchmarks
branch
from
9c51c74
to
faae95f
Compare
aborg-dev
force-pushed
the
build_benchmarks
branch
from
faae95f
to
6a469f6
Compare
I've tried to polish the approach based on build-artifacts but it was too inflexible - I wasn't able to fully customize build profile and flags used by the artifact. On top of that, it required using nightly Cargo which generated tons of warnings. So I migrated the implementation to build.rs based on the approach taken by https://github.com/near/nearcore/tree/master/runtime/near-test-contracts. This worked like a charm and I think it's ready for a high-level review. Based on artifact-dependencies to compile Rust to WASM during build.
aborg-dev
force-pushed
the
build_benchmarks
branch
from
6a469f6
to
ca2f1d0
Compare
|
I've resolved all comments, PTAL |
nagisa
approved these changes
Mar 5, 2024
mooori
approved these changes
Mar 6, 2024
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MVP that we built during the programming session. Let's see if CI likes it :)
UPD: I've tried to polish the approach based on build-artifacts but it was too inflexible - I wasn't able to fully customize build profile and flags used by the artifact. On top of that, it required using nightly Cargo which generated tons of warnings.
So I migrated the implementation to
build.rsbased on the approach taken by https://github.com/near/nearcore/tree/master/runtime/near-test-contracts. This worked like a charm and I think it's ready for a high-level review.