Use stable path to node module #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
approved these changes
Mar 4, 2024
Comment on lines
83
to
82
| .to_str() | ||
| .unwrap() | ||
| .to_string(); |
There was a problem hiding this comment.
Suggested change
| .to_str() | |
| .unwrap() | |
| .to_string(); | |
| .display() | |
| .to_string(); |
Ideally this did not force filesystem paths to be utf-8, but I can imagine that npm or node in general won't take kindly to it anyway, so whatever. And I don't think any of us will have non-utf-8 working directories...
That said there's a caveat with file! -- it is affected by the --remap-path-prefix flag so if for any reason that flag is used, this code will most likely break. An alternative could be to use env!("CARGO_MANIFEST_DIR") and base the path from that.
There was a problem hiding this comment.
Both great points, thanks! I ended up switching to CARGO_MANIFEST_DIR which uses an absolute path.
aborg-dev
force-pushed
the
stable_path_to_node
branch
from
88f17f7
to
9147824
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #238