Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filetests]: results pretty-print #247

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MCJOHN974
Copy link

Here I implemented pretty printing of error in case of test fail. Need some refactoring in and code style improvements but in general it works

@MCJOHN974 MCJOHN974 marked this pull request as ready for review March 8, 2024 10:54
Base automatically changed from viktar/filetests to main March 13, 2024 14:18
@MCJOHN974 MCJOHN974 force-pushed the viktar/test-results-printing branch from c3ef7de to a825456 Compare March 13, 2024 17:09
@MCJOHN974
Copy link
Author

This pretty-print PR changes old assert to new one, so it should be merged after whole migrating

@@ -79,6 +98,24 @@ impl SubTest for TestRunZkasm {
debug_assert!(matches!(execution_result.status, ExecutionStatus::Success));
// TODO: Probably here is a good place to collect info generated by assert-hostfunction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addressed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's outdated, thanks


#[derive(Deserialize, Debug, PartialEq)]
#[serde(rename_all = "camelCase")]
enum TestStatus {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enum used anywhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants