-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filetests]: results pretty-print #247
base: main
Are you sure you want to change the base?
Conversation
c3ef7de
to
a825456
Compare
This pretty-print PR changes old assert to new one, so it should be merged after whole migrating |
@@ -79,6 +98,24 @@ impl SubTest for TestRunZkasm { | |||
debug_assert!(matches!(execution_result.status, ExecutionStatus::Success)); | |||
// TODO: Probably here is a good place to collect info generated by assert-hostfunction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's outdated, thanks
|
||
#[derive(Deserialize, Debug, PartialEq)] | ||
#[serde(rename_all = "camelCase")] | ||
enum TestStatus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this enum used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Here I implemented pretty printing of error in case of test fail. Need some refactoring in and code style improvements but in general it works