Fix: external linked issues notification

package.json

@@ -19,7 +19,9 @@
     "@actions/core": "^1.10.0",
     "@actions/github": "^5.1.1",
     "adm-zip": "^0.5.9",
+    "lodash.isequal": "^4.5.0",
     "lodash.template": "^4.5.0",
+    "lodash.uniqwith": "^4.5.0",
     "markdown-it": "^13.0.1",
     "node-fetch": "^2.6.6",
     "p-map": "^4.0.0",

src/utils/notifyIssues.js

@@ -2,6 +2,7 @@
 
 const fs = require('fs')
 const pMap = require('p-map')
+const { logWarning } = require('../log')
 
 const { getPrNumbersFromReleaseNotes } = require('./releaseNotes')
 
@@ -16,6 +17,12 @@ async function getLinkedIssueNumbers(github, prNumber, repoOwner, repoName) {
             nodes {
               id
               number
+              repository {
+                name
+                owner {
+                  login
+                }
+              }
             }
           }
         }
@@ -36,7 +43,11 @@ async function getLinkedIssueNumbers(github, prNumber, repoOwner, repoName) {
     return []
   }
 
-  return linkedIssues.map(issue => issue.number)
+  return linkedIssues.map(issue => ({
+    issueNumber: issue.number,
+    repoName: issue?.repository?.name,
+    repoOwner: issue?.repository?.owner?.login,
+  }))
 }
 
 function createCommentBody(
@@ -97,18 +108,33 @@ async function notifyIssues(
     releaseUrl
   )
 
-  await pMap(
-    issueNumbersToNotify,
-    issueNumber => {
-      githubClient.rest.issues.createComment({
-        owner,
-        repo,
+  const mapper = async ({ issueNumber, repoOwner, repoName }) => {
+    try {
+      if (repoOwner !== owner || repoName !== repo) {
+        logWarning(
+          `Skipping external issue-${issueNumber}, repoOwner-${repoOwner} , repo-${repoName}`
+        )
+        return pMap.pMapSkip
+      }
+
+      return await githubClient.rest.issues.createComment({
+        owner: repoOwner,
+        repo: repoName,
         issue_number: issueNumber,
         body,
       })
-    },
-    { concurrency: 10 }
-  )
+    } catch (error) {
+      logWarning(
+        `Failed to create comment for issue-${issueNumber}, repo-${repoName}. Error-${error.message}`
+      )
+      return pMap.pMapSkip
+    }
+  }
+
+  await pMap(issueNumbersToNotify, mapper, {
+    concurrency: 10,
+    stopOnError: false,
+  })
 }
 
 exports.notifyIssues = notifyIssues

src/utils/releaseNotes.js

@@ -3,7 +3,7 @@
 const md = require('markdown-it')()
 
 function getPrNumbersFromReleaseNotes(releaseNotes) {
-  const parsedReleaseNotes = md.parse(releaseNotes)
+  const parsedReleaseNotes = md.parse(releaseNotes, {})
   const prTokens = parsedReleaseNotes.filter(token => token.type === 'inline')
 
   const allPrNumbers = prTokens

test/notifyIssues.test.js

@@ -59,6 +59,51 @@ tap.test('Should not call createComment if no linked issues', async () => {
   sinon.assert.notCalled(createCommentStub)
 })
 
+tap.test(
+  'Should not call createComment if linked issue belongs to external repo',
+  async () => {
+    const { notifyIssues } = setup()
+
+    const releaseNotes = `
+      ## What's Changed\n +
+      * chore 15 by @people in https://github.com/owner/repo/pull/13\n
+      \n
+      \n
+      **Full Changelog**: https://github.com/owner/repo/compare/v1.0.20...v1.1.0
+    `
+
+    const release = { body: releaseNotes, html_url: 'some_url' }
+
+    const graphqlStub = sinon.stub().resolves({
+      repository: {
+        pullRequest: {
+          closingIssuesReferences: {
+            nodes: [
+              {
+                number: '13',
+                repository: {
+                  name: 'ext-repo',
+                  owner: { login: 'ext-owner' },
+                },
+              },
+            ],
+          },
+        },
+      },
+    })
+
+    await notifyIssues(
+      { ...DEFAULT_GITHUB_CLIENT, graphql: graphqlStub },
+      false,
+      'owner',
+      'repo',
+      release
+    )
+
+    sinon.assert.notCalled(createCommentStub)
+  }
+)
+
 tap.test(
   'Should call createComment with correct arguments for linked issues with npm link',
   async () => {
@@ -78,7 +123,22 @@ tap.test(
       repository: {
         pullRequest: {
           closingIssuesReferences: {
-            nodes: [{ number: '10' }, { number: '15' }],
+            nodes: [
+              {
+                number: '10',
+                repository: {
+                  name: 'repo',
+                  owner: { login: 'owner' },
+                },
+              },
+              {
+                number: '15',
+                repository: {
+                  name: 'repo',
+                  owner: { login: 'owner' },
+                },
+              },
+            ],
           },
         },
       },
@@ -137,7 +197,22 @@ tap.test(
       repository: {
         pullRequest: {
           closingIssuesReferences: {
-            nodes: [{ number: '10' }, { number: '15' }],
+            nodes: [
+              {
+                number: '10',
+                repository: {
+                  name: 'repo',
+                  owner: { login: 'owner' },
+                },
+              },
+              {
+                number: '15',
+                repository: {
+                  name: 'repo',
+                  owner: { login: 'owner' },
+                },
+              },
+            ],
           },
         },
       },