Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for agent option. [#78] #81

Merged
merged 2 commits into from
Oct 1, 2021
Merged

feat: Added support for agent option. [#78] #81

merged 2 commits into from
Oct 1, 2021

Conversation

ShogunPanda
Copy link
Contributor

This adds the agent option, which will be forward to fetch.

simoneb
simoneb approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect 💯

mcollina
mcollina approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simoneb
Copy link
Member

simoneb commented Oct 1, 2021

@ShogunPanda before merging can you please link it to the issue?

@ShogunPanda
Copy link
Contributor Author

Absolutely. I will in the next hour.

@simoneb simoneb linked an issue Oct 1, 2021 that may be closed by this pull request
support agent option #78
Closed
@simoneb simoneb merged commit 877223d into main Oct 1, 2021
@simoneb simoneb deleted the undici-and-agent branch October 1, 2021 13:41
@github-actions github-actions bot mentioned this pull request Oct 2, 2021
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

@mcollina mcollina mcollina approved these changes

@p16 p16 Awaiting requested review from p16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support agent option
3 participants
@ShogunPanda @simoneb @mcollina