-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up test suite #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmullan91
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - one minor suggestion RE the imports
test/unit/createClient.test.js
Outdated
@@ -0,0 +1,5 @@ | |||
import createClient from '../../src/createClient'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: perhaps we should be importing from the package entry point:
import { createClient } from '../../src'
jackdclark
pushed a commit
that referenced
this pull request
Mar 1, 2019
jackdclark
added a commit
that referenced
this pull request
Mar 5, 2019
* lerna init & move graphql-hooks to packages * update root scripts * update circleci * first * update quickstart guide * v1.0.1 * Add renovate.json (#2) * Pin dependencies (#3) * Update react monorepo to v16.8.3 (#4) * first * use prettier * v1.0.1 * reademe -> readme... doh * v1.0.2 * use fnv1a algo for object hashing * v1.0.3 * update package.json repo, bugs and homepage links * v1.0.4 * Add renovate.json (#2) * Pin dependencies (#3) * exit 0 for new packages * Create jest config for packages * move coveralls reporting to root * run root coveralls in ci * Remove duplicate files from packages * update README * update eslint & prettier paths * add npm release & update CONTRIBUTING.md * relative packages in README * tidy package.json for packages * update issue templates * prettier babel config * remove test test * Update lint-staged config * Update eslint command * Add note to CONTRIBUTING about lerna * remove jest from package dir * update graphql-hooks-memcache to latest * Update eslint/prettier paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Set up the foundation for a test suite including the following
jest
withreact-testing-library