Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up test suite #4

Merged
merged 8 commits into from
Feb 14, 2019
Merged

Set up test suite #4

merged 8 commits into from
Feb 14, 2019

Conversation

jackdclark
Copy link
Member

Closes #3

Set up the foundation for a test suite including the following

  • jest with react-testing-library
  • CircleCI running tests + badge
  • Coverage reprorting in Coveralls + badge
  • Empty test files

Copy link
Contributor

@bmullan91 bmullan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - one minor suggestion RE the imports

@@ -0,0 +1,5 @@
import createClient from '../../src/createClient';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: perhaps we should be importing from the package entry point:

import { createClient } from '../../src'

@jackdclark jackdclark merged commit 0fa7a67 into master Feb 14, 2019
@jackdclark jackdclark deleted the test-suite branch February 14, 2019 11:41
jackdclark pushed a commit that referenced this pull request Mar 1, 2019
jackdclark added a commit that referenced this pull request Mar 5, 2019
* lerna init & move graphql-hooks to packages

* update root scripts

* update circleci

* first

* update quickstart guide

* v1.0.1

* Add renovate.json (#2)

* Pin dependencies (#3)

* Update react monorepo to v16.8.3 (#4)

* first

* use prettier

* v1.0.1

* reademe -> readme... doh

* v1.0.2

* use fnv1a algo for object hashing

* v1.0.3

* update package.json repo, bugs and homepage links

* v1.0.4

* Add renovate.json (#2)

* Pin dependencies (#3)

* exit 0 for new packages

* Create jest config for packages

* move coveralls reporting to root

* run root coveralls in ci

* Remove duplicate files from packages

* update README

* update eslint & prettier paths

* add npm release & update CONTRIBUTING.md

* relative packages in README

* tidy package.json for packages

* update issue templates

* prettier babel config

* remove test test

* Update lint-staged config

* Update eslint command

* Add note to CONTRIBUTING about lerna

* remove jest from package dir

* update graphql-hooks-memcache to latest

* Update eslint/prettier paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants