Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update apq middleware build #839

Merged
merged 22 commits into from
May 3, 2022
Merged

fix: update apq middleware build #839

merged 22 commits into from
May 3, 2022

Conversation

ianlnf
Copy link
Contributor

@ianlnf ianlnf commented Apr 28, 2022 •
edited
Loading

  • Replaces @aws-crypto/sha256-universal with @aws-crypto/sha256-browser
  • APQMiddleware now a named export
  • Replaces TestCafe with Cypress
  • Runs acceptance tests on CI

resolves #819

@simoneb
Copy link
Member

simoneb commented Apr 28, 2022

@rp4rk is looking into #838 which has also to do with typings, let's make sure we come to an organic solution

@rp4rk
Copy link
Contributor

rp4rk commented Apr 29, 2022

This LGTM so far

@ianlnf ianlnf marked this pull request as ready for review May 3, 2022 09:09
rp4rk
rp4rk approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@rp4rk rp4rk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I've noticed but I don't think any of them are huge blockers at all if they prove to be oversights, otherwise LGTM :)

examples/create-react-app/src/App.js
@@ -1,5 +1,7 @@
import React, { useState } from 'react'
import { GraphQLClient, ClientContext } from 'graphql-hooks'
// eslint-disable-next-line no-unused-vars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was including this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the APQ issue with crypto not being polyfilled with webpack 5 only surfaces when the middleware is imported, once #847 is complete, that example could be used for the acceptance tests

packages/graphql-hooks/rollup.config.js Outdated Show resolved Hide resolved
@ianlnf ianlnf merged commit 0f5a91f into master May 3, 2022
@ianlnf ianlnf deleted the fix/819-apq-build branch May 3, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rp4rk rp4rk rp4rk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is APQ working?
3 participants
@ianlnf @simoneb @rp4rk