Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Login flow fails if performed immediately after logging out #41

Closed
wants to merge 2 commits into from

Conversation

n370
Copy link
Contributor

@n370 n370 commented Mar 1, 2021

Closes: #17

This PR adds:

  • Wraps third-party async functions in try/catch blocks where appropriate setting the pattern for proper error handling in the future.
  • Preload static assets using the expo-asset library.
  • Bumps expo-auth-session library to new version that fixes the login issue.

@n370 n370 changed the title fix: wip fix | Login flow fails if performed immediately after logging out Mar 1, 2021
@n370 n370 force-pushed the fix/authentication-flow-not-working-twice branch from f782fd0 to 3ce2e1e Compare March 2, 2021 20:48
@n370
Copy link
Contributor Author

n370 commented Mar 2, 2021

@simoneb you may want to keep this branch around and use it to add the commit upgrading the auth library when the fixed version is ready. If you do so you can take advantage of a few small improvements I made here while looking for what was causing this issue.

@n370 n370 changed the title fix | Login flow fails if performed immediately after logging out Fix | Login flow fails if performed immediately after logging out Mar 3, 2021
@n370
Copy link
Contributor Author

n370 commented May 5, 2021

@simoneb I'm not sure you want this draft to stay around any longer. Did y'all found a solution for this already?

@simoneb
Copy link
Member

simoneb commented May 6, 2021

@simoneb I'm not sure you want this draft to stay around any longer. Did y'all found a solution for this already?

Let's keep it here for reference until it's solved. We know what the issue is but your work here may be useful nonetheless. I'll keep track of this, no worries.

@salmanm salmanm closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale UI state on second login
3 participants