This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
node 10 check #533
Merged
node 10 check #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberesford
approved these changes
May 9, 2018
dberesford
pushed a commit
that referenced
this pull request
May 11, 2018
* constraints added to db tables and validation to check entity ids... * enforcing hyphenated ids, paths translated to underscore * tests to check for invalid id characters across entities * Fix for udaru bin (#530) * node 10 check (#533) * update of swagger json (#532) * update of swagger json * latest swagger-ui-dist * swagger-gen removed * policy assignment must use objects (#535) * policy assignment must use objects * label update for swagger docs * deleting for merge * merge fix * Merge swagger and validation (#536) * merge joi swagger with validation into core * constraints added to db tables and validation to check entity ids... * enforcing hyphenated ids, paths translated to underscore * master merge * no longer generated * removed after rebase * no longer user to inject (static in docs/swagger/index.htm)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues here with global leaks in core and hapi-16-plugin, we don't have the issue when using lab15 with hapi 17. I tried upgrading dependencies etc, and I removed all tests and the leaks were still occurring so it doesn't seem to be a runtime udaru issue but rather some issue with node10/lab14/dependencies. I've put in two globals for the items URL & URLSearchParams into .labrc.js files to bypass... these should be removed once lab is upgrade for core and hapi-16, they're not necessary for hapi 17 plugin, which uses lab 15+
I've taken the command line args from package.json lab entries (except for coverage docs) in favour of using labrc.js file for consistency (there's no point having global exclusions polluting package.json files)