Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

policy assignment must use objects #535

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

cianfoley-nearform
Copy link
Contributor

@cianfoley-nearform cianfoley-nearform commented May 9, 2018

lots of test updates because of one small validation change...

here we are enforcing the use of an object when associating policies as we would if creating a policy instance. Essentially associating a policy with an udaru entity is a policy instance with no variables set anyway, so here we re-use the same object for associating both

swagger documentation is now free of generic objects and does not default to string under POST/PUTs under each entity type.

This is the issue this is addressing: #522

readme may need to be updated

@coveralls
Copy link

coveralls commented May 9, 2018

Coverage Status

Coverage decreased (-0.02%) to 92.985% when pulling ae0064f on remove-joi-alternatives into 36aec3a on master.

Copy link
Contributor

@dberesford dberesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dberesford dberesford merged commit 363faee into master May 10, 2018
@dberesford dberesford deleted the remove-joi-alternatives branch May 10, 2018 12:57
dberesford pushed a commit that referenced this pull request May 11, 2018
* constraints added to db tables and validation to check entity ids...

* enforcing hyphenated ids, paths translated to underscore

* tests to check for invalid id characters across entities

* Fix for udaru bin (#530)

* node 10 check (#533)

* update of swagger json (#532)

* update of swagger json

* latest swagger-ui-dist

* swagger-gen removed

* policy assignment must use objects (#535)

* policy assignment must use objects

* label update for swagger docs

* deleting for merge

* merge fix

* Merge swagger and validation (#536)

* merge joi swagger with validation into core

* constraints added to db tables and validation to check entity ids...

* enforcing hyphenated ids, paths translated to underscore

* master merge

* no longer generated

* removed after rebase

* no longer user to inject (static in docs/swagger/index.htm)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants