Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export basic types directly instead of vm-logic #81

Closed
ilblackdragon opened this issue Feb 5, 2020 · 2 comments
Closed

Export basic types directly instead of vm-logic #81

ilblackdragon opened this issue Feb 5, 2020 · 2 comments

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented Feb 5, 2020

Currently basic types like BlocmHeight used inside Bindgen but also client contracts need also import them from near-vm-logic
It's very confusing and adds extra dependency that can be misaligned (like right now with crate.io having 0.4.4 whereas Bindgen depended on 0.4.3).

Ideally Bindgen should just export these types itself and client contracts don't need to depend directly on near-vm-logic.

@MaksymZavershynskyi
Copy link
Contributor

Moving to Backlog and assigning P2 since we will be cleaning up near-bindgen soon anyway.

@austinabell
Copy link
Contributor

Closing, only unit testing (non-wasm32) depends on nearcore crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants