Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move network requests to ViewClient #1955

Merged
merged 6 commits into from
Jan 15, 2020

Conversation

bowenwang1996
Copy link
Collaborator

Fixes #1926

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1955 into staging will decrease coverage by 0.03%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1955      +/-   ##
===========================================
- Coverage    86.61%   86.57%   -0.04%     
===========================================
  Files          167      167              
  Lines        31517    31618     +101     
===========================================
+ Hits         27297    27372      +75     
- Misses        4220     4246      +26
Impacted Files Coverage Δ
core/primitives/src/views.rs 60.34% <100%> (+0.2%) ⬆️
core/primitives/src/merkle.rs 100% <100%> (ø) ⬆️
core/primitives/src/block.rs 97.11% <92.85%> (+0.08%) ⬆️
chain/chain/src/test_utils.rs 79.88% <0%> (-4.25%) ⬇️
chain/client/src/client.rs 92.98% <0%> (-1.35%) ⬇️
chain/client/src/types.rs 82.03% <0%> (-0.79%) ⬇️
chain/chain/src/validate.rs 90.87% <0%> (-0.37%) ⬇️
chain/network/src/peer_manager.rs 76.94% <0%> (-0.15%) ⬇️
...enesis-tools/genesis-csv-to-json/src/serde_with.rs 100% <0%> (ø) ⬆️
runtime/runtime/tests/test_evil_contracts.rs 100% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dc6c2...8920648. Read the comment docs.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 1f5eab0 into staging Jan 15, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the move-to-view-client branch January 15, 2020 19:29
SkidanovAlex pushed a commit that referenced this pull request Jan 29, 2020
* Move network requests to ViewClient
* fix tests
* Merge branch 'staging' into move-to-view-client
* Fix test
* Merge branch 'staging' into move-to-view-client
* Merge refs/heads/staging into move-to-view-client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants