-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move network requests to ViewClient #1955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
MaksymZavershynskyi and
SkidanovAlex
as code owners
January 14, 2020 22:46
SkidanovAlex
approved these changes
Jan 14, 2020
Codecov Report
@@ Coverage Diff @@
## staging #1955 +/- ##
===========================================
- Coverage 86.61% 86.57% -0.04%
===========================================
Files 167 167
Lines 31517 31618 +101
===========================================
+ Hits 27297 27372 +75
- Misses 4220 4246 +26
Continue to review full report at Codecov.
|
bowenwang1996
force-pushed
the
move-to-view-client
branch
from
January 15, 2020 03:19
ab5194a
to
85a0ac9
Compare
SkidanovAlex
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Move network requests to ViewClient * fix tests * Merge branch 'staging' into move-to-view-client * Fix test * Merge branch 'staging' into move-to-view-client * Merge refs/heads/staging into move-to-view-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1926