-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Pydantic V2 [Wait til after 2024.4.1 release to merge] #2348
Conversation
Looks like the Local Integration Tests started failing when I merged in develop branch, which was only updating the azurerm provider version, which passed tests on its PR. Not sure why it's failing now. I also deployed this locally, and it seems to be running fine. Update: I see that the test uses the "main" image tags so the error is probably due to a recent change in nebari-docker-images repo. Update2: Fixed now |
@Adam-D-Lewis I am seeing the same behavior in #2375. Did the Cypress tests succeed when running them locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
We are waiting to merge until after 2024.4.1 release to merge to give certain developers of Nebari extensions a chance to test them before we merge. |
@Adam-D-Lewis should we add a |
@Adam-D-Lewis should we test whether upgrading from the last stable version to this does not result in any potential changes (e.g., terraform infrastructure being forced to be replaced or the C.C.: @viniciusdc |
Yes, it'd be good to test the upgrade. |
As an update, I tested the upgrade from 2024.3.3 on a local deployment and everything went smoothly. No infrastructure was replaced, etc. |
This reverts commit 85d3a75.
Reference Issues or PRs
This is a continuation of @fangchenli's work - #1928
Fixes #2343
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?