Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pydantic V2 [Wait til after 2024.4.1 release to merge] #2348

Merged
merged 117 commits into from
Apr 22, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 19, 2024

Reference Issues or PRs

This is a continuation of @fangchenli's work - #1928
Fixes #2343

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Upgrade dependencies

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title Upgrade to Pydantic V2 [WIP] Upgrade to Pydantic V2 Apr 4, 2024
@Adam-D-Lewis Adam-D-Lewis added needs: review 👀 This PR is complete and ready for reviewing and removed status: in progress 🏗 This task is currently being worked on labels Apr 4, 2024
@Adam-D-Lewis Adam-D-Lewis mentioned this pull request Apr 4, 2024
10 tasks
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Apr 4, 2024

Looks like the Local Integration Tests started failing when I merged in develop branch, which was only updating the azurerm provider version, which passed tests on its PR. Not sure why it's failing now. I also deployed this locally, and it seems to be running fine.

Update: I see that the test uses the "main" image tags so the error is probably due to a recent change in nebari-docker-images repo.

Update2: Fixed now

@marcelovilla
Copy link
Member

@Adam-D-Lewis I am seeing the same behavior in #2375. Did the Cypress tests succeed when running them locally?

Look at this screenshot from the failing test:
First Test -- Check Nebari login and start JupyterLab (failed)

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Apr 4, 2024

We are waiting to merge until after 2024.4.1 release to merge to give certain developers of Nebari extensions a chance to test them before we merge.

@marcelovilla
Copy link
Member

We are waiting to merge until April 12 to give certain developers of Nebari extensions a chance to test them before we merge.

@Adam-D-Lewis should we add a [DO NOT MERGE] to the title just in case?

@Adam-D-Lewis Adam-D-Lewis changed the title Upgrade to Pydantic V2 Upgrade to Pydantic V2 [Wait til Apr 12 to merge] Apr 4, 2024
@marcelovilla
Copy link
Member

@Adam-D-Lewis should we test whether upgrading from the last stable version to this does not result in any potential changes (e.g., terraform infrastructure being forced to be replaced or the render command not working properly or as expected)? I don't think that's going to be the case but it might be worth to take a look at. I can help with that if necessary.

C.C.: @viniciusdc

@Adam-D-Lewis
Copy link
Member Author

Yes, it'd be good to test the upgrade.

@Adam-D-Lewis Adam-D-Lewis changed the title Upgrade to Pydantic V2 [Wait til Apr 12 to merge] Upgrade to Pydantic V2 [Wait til after 2024.4.1 release to merge] Apr 10, 2024
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Apr 10, 2024

As an update, I tested the upgrade from 2024.3.3 on a local deployment and everything went smoothly. No infrastructure was replaced, etc.

@Adam-D-Lewis Adam-D-Lewis mentioned this pull request Apr 15, 2024
10 tasks
@Adam-D-Lewis Adam-D-Lewis merged commit 85d3a75 into develop Apr 22, 2024
28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the pydantic2 branch April 22, 2024 14:39
Adam-D-Lewis added a commit that referenced this pull request Apr 22, 2024
@Adam-D-Lewis Adam-D-Lewis restored the pydantic2 branch April 22, 2024 16:49
@Adam-D-Lewis Adam-D-Lewis mentioned this pull request Apr 22, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies needs: review 👀 This PR is complete and ready for reviewing
Projects
Development

Successfully merging this pull request may close these issues.

Update from Pydantic V1 to Pydantic V2
4 participants