Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Diagnostics production parameter aware #468

Open
3 tasks
MuratUrsavas opened this issue Jan 27, 2023 · 8 comments
Open
3 tasks

Make Diagnostics production parameter aware #468

MuratUrsavas opened this issue Jan 27, 2023 · 8 comments

Comments

@MuratUrsavas
Copy link
Contributor

Acceptance Criteria

  • Diagnostics has to recognize new Docker volume /var/nebra
  • It should be able to create necessary scripts even for the devices already on field
  • Diagnostics will be the primary responsible to track these environment variables
MuratUrsavas added a commit that referenced this issue Feb 1, 2023
…tion

Added production parameter recognition feature (#468)
@shawaj
Copy link
Member

shawaj commented Feb 1, 2023

Related to #444

@shawaj
Copy link
Member

shawaj commented Feb 5, 2023

@MuratUrsavas we need to make sure this works for non Nebra devices. Currently it fails...

NebraLtd/hm-pktfwd#123

Maybe for non Nebra we can just have it put a value of none in the file?

@shawaj
Copy link
Member

shawaj commented Feb 6, 2023

@MuratUrsavas I suppose the other way we could solve this is to just set all non-Nebra fleets to have a FREQ variable set to something like N/A (Non Nebra Miner)

Then we wouldn't need to make any code changes.

What do you think?

@MuratUrsavas
Copy link
Contributor Author

MuratUrsavas commented Feb 6, 2023

@shawaj Actually I was expecting a mandatory FREQ parameter, but you're right. It has to be optional. Let me fix it.

@shawaj
Copy link
Member

shawaj commented Feb 6, 2023

This one just fails silently already right @MuratUrsavas ?

https://github.com/NebraLtd/hm-diag/blob/master/setenv.sh

@MuratUrsavas
Copy link
Contributor Author

@shawaj It's actually not failing. Just prompts an error if cannot reach them from both of the sources. But it continues to work if not exists.

@shawaj
Copy link
Member

shawaj commented Feb 6, 2023

Perfect

@shawaj
Copy link
Member

shawaj commented Jun 6, 2023

@MuratUrsavas @KevinWassermann94 guessing we can close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants