-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Diagnostics production parameter aware #468
Comments
…tion Added production parameter recognition feature (#468)
Related to #444 |
@MuratUrsavas we need to make sure this works for non Nebra devices. Currently it fails... Maybe for non Nebra we can just have it put a value of none in the file? |
@MuratUrsavas I suppose the other way we could solve this is to just set all non-Nebra fleets to have a Then we wouldn't need to make any code changes. What do you think? |
@shawaj Actually I was expecting a mandatory FREQ parameter, but you're right. It has to be optional. Let me fix it. |
This one just fails silently already right @MuratUrsavas ? |
@shawaj It's actually not failing. Just prompts an error if cannot reach them from both of the sources. But it continues to work if not exists. |
Perfect |
@MuratUrsavas @KevinWassermann94 guessing we can close this now? |
Acceptance Criteria
/var/nebra
The text was updated successfully, but these errors were encountered: