feat: add FREQ env variable to Balena.ymls #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add FREQ env vars to balena.yml files to fix pktfwd container crashing issue
shawaj
force-pushed
the
shawaj/freqenv
branch
from
604d9be
to
58c9827
Compare
|
@shawaj I don't think this is necessary. And also would lead some issues about the tasks we're planning. It will give false positives that FREQ has been set. |
|
@MuratUrsavas why would it effect anything we are planning? This is mainly so it doesn't show an empty frequency for people using "deploy with Balena" button. It won't effect our fleets for our own miners, just when other people deploy a fleet |
KevinWassermann94
approved these changes
Feb 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
How
Screenshots
References
Checklist