Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct issues with parsing statements #36

Merged
merged 12 commits into from
Feb 19, 2023

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 12, 2023

Changes:

  • Correct shortcut i in npm conversion
  • add support for -D, -S, -E, -O npm shortcuts
  • correct issue with rebuild and --force install
  • do not modify args that are part of string eg, package name my--save-dev
  • add support for -- in commands
  • add support for exec commands
  • correct pattern matching for li/list
  • correct minor issue with --exact/optional/dev
  • correct parsing list --production and --development
  • yarn: add support for global list
  • yarn: update conversion of global add/remove to reuse logic of add/remove
  • add more test cases

fixes armano2#7
fixes armano2#6

@armano2 armano2 changed the title fix/update package fix: correct issues with parsing statements Feb 12, 2023
@nebrelbug
Copy link
Owner

@armano2 thanks so much for the PR! These are awesome changes that will make the library much more robust. My one quibble is that I think npm unlink should change to yarn unlink. Am I missing something there?

After I merge this PR, I'll add a few more tests to meet the coverage threshold and then publish a new version.

@nebrelbug
Copy link
Owner

Also, would you be interested in being added as a maintainer?

@armano2
Copy link
Contributor Author

armano2 commented Feb 14, 2023

@armano2 thanks so much for the PR! These are awesome changes that will make the library much more robust. My one quibble is that I think npm unlink should change to yarn unlink. Am I missing something there?

hmm i didn't think about this use case, def we should update unlink and link

After I merge this PR, I'll add a few more tests to meet the coverage threshold and then publish a new version.

i added alot of test cases but we are missing some, esp, for those aliases

@armano2
Copy link
Contributor Author

armano2 commented Feb 15, 2023

@nebrelbug link/unlink added and their aliases

@armano2 armano2 mentioned this pull request Feb 18, 2023
@nebrelbug
Copy link
Owner

@armano2 thank you! I'll merge this now.

@nebrelbug nebrelbug merged commit 6d1b43e into nebrelbug:master Feb 19, 2023
@armano2 armano2 deleted the fix/update-package branch February 19, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--save-exact for npm install isn't converted correctly Not sure if npm run is transformed correctly
2 participants