Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: npm to pnpm #37

Merged
merged 4 commits into from
Feb 20, 2023
Merged

feat: npm to pnpm #37

merged 4 commits into from
Feb 20, 2023

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 18, 2023

Add support for all command that are support in npm to yarn to work with pnpm

Changes:

  • add support for npm to pnpm
  • add missing conversion for npm outdated
  • add missing conversion for npm pack
  • add more tests for npm to yarn

fixes #34 ref babel/website#2725

@armano2 armano2 marked this pull request as draft February 18, 2023 22:01
@armano2 armano2 changed the title feat/npm to pnpm feat: npm to pnpm Feb 18, 2023
@nebrelbug
Copy link
Owner

Thank you for another helpful PR! I just merged #36, so you can rebase it now.

@armano2 armano2 marked this pull request as ready for review February 19, 2023 13:27
@armano2
Copy link
Contributor Author

armano2 commented Feb 19, 2023

@nebrelbug rebased, i noticed few additional issues with converting and fixed them

I also added few new test cases

@liuxingbaoyu
Copy link

Wow! Amazing work, thank you so much!

@nebrelbug
Copy link
Owner

@armano2 thank you! I'll merge this now.

@nebrelbug nebrelbug merged commit 57a9cd9 into nebrelbug:master Feb 20, 2023
@nebrelbug
Copy link
Owner

I just released this as part of version 2.0.0!

@Zamiell
Copy link

Zamiell commented Feb 20, 2023

thanks armano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pnpm
4 participants