Shell-escape tasks before passing them to capistrano

[njam]

When I try to to use the invoke command I have the problem that the COMMAND='some command' is not being escaped before passed to capistrano.
Let's say I run:

pulsar -v -l trace app env invoke COMMAND='uname -a'

Pulsar will eventually run:

bundle exec cap CONFIG_PATH=/tmp/pulsar/conf-repo-2013-07-23-183838-s5061 --file /tmp/pulsar/capfile-2013-07-23-183838-s5061 invoke COMMAND=uname -a

which doesn't work and results in:

/usr/local/homebrew/Cellar/ruby/2.0.0-p247/lib/ruby/gems/2.0.0/gems/capistrano-2.15.5/lib/capistrano/cli/options.rb:154:in `parse_options!': invalid option: -a (OptionParser::InvalidOption)
    from /usr/local/homebrew/Cellar/ruby/2.0.0-p247/lib/ruby/gems/2.0.0/gems/capistrano-2.15.5/lib/capistrano/cli/options.rb:15:in `parse'
    from /usr/local/homebrew/Cellar/ruby/2.0.0-p247/lib/ruby/gems/2.0.0/gems/capistrano-2.15.5/lib/capistrano/cli/execute.rb:14:in `execute'
    from /usr/local/homebrew/Cellar/ruby/2.0.0-p247/lib/ruby/gems/2.0.0/gems/capistrano-2.15.5/bin/cap:4:in `<top (required)>'
    from /usr/local/opt/ruby/bin/cap:23:in `load'
    from /usr/local/opt/ruby/bin/cap:23:in `<main>'

[coveralls]

Coverage remained the same when pulling 64d6a3d on njam:issue-12 into e06c151 on nebulab:master.

[njam]

Is this the right approach, escaping the task list?
Can you point me into the right direction as how/where to test this?

With this patch the command executed by pulsar will become invoke COMMAND\=uname\ -a.

[mtylty]

@njam great! it seems something really handy!

Just one thing before I merge the pull request; you should move the require inside https://github.com/nebulab/pulsar/blob/master/lib/pulsar.rb. You can add the require before require "pulsar/helpers/all".

[mtylty]

I'm going to release a bugfix version now. I'll merge and make the change myself.

Thanks for the PR!

[njam]

Oh, I actually had it in lib/pulsar.rb but moved it back into the file. The whole structuring with ruby is still nebulous to me. Thanks for adjusting it!

[mtylty]

no problem! 😄