Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant text-transform for FF's select #828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SiarheiBobryk
Copy link

Nowadays we don't need to specify the text-transform property for the
select element for Firefox. Such functionality already built-in in
Firefox as well as for all other browsers normalise.css supports:
Chrome, Safari, Edge, IE11, IE10.

Sources:

Other changes:

  • Specify IE supported versions because we still need to set
    text-transform for button in Edge, IE11, and IE10 explicitly.
  • Remove select from the text-transform UI test

Tested on:

  • Safari 13.1.2
  • Chrome 85.0.4183.102
  • Firefox 80.0.1
  • Edge 44.19041.423.0
  • IE 11.450.19041.0
  • IE 10.0.9200.16384

Nowadays we don't need to specify the text-transform property for the
select element for Firefox. Such functionality already built-in in
Firefox as well as for all other browsers normalise.css supports:
Chrome, Safari, Edge, IE11, IE10.

Sources:
- [Firefox's forms.css](https://dxr.mozilla.org/mozilla-central/source/layout/style/res/forms.css#133)
- `view-source:resource://gre-resources/forms.css`

Other changes:
- Specify IE supported versions because we still need to set
text-transform for button in Edge, IE11, and IE10 explicitly.
- Remove select from the text-transform UI test

Tested on:
- Safari 13.1.2
- Chrome 85.0.4183.102
- Firefox 80.0.1
- Edge 44.19041.423.0
- IE 11.450.19041.0
- IE 10.0.9200.16384
@SiarheiBobryk
Copy link
Author

Screen Shot 2020-09-15 at 12 18 58 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant