Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link: Allow explicit rel="opener" #1428

Closed
wants to merge 2 commits into from
Closed

Link: Allow explicit rel="opener" #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4cf283
Allow explicit rel="opener"
sstur Sep 10, 2019
64bf0fb
Remove Set() from dedup logic
sstur Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/react-native-web/src/modules/createDOMProps/__tests__/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`modules/createDOMProps includes "rel" values for "a" elements (to securely open external links) 1`] = `" noopener noreferrer"`;
exports[`modules/createDOMProps includes "rel" values for "a" elements (to securely open external links) 1`] = `"noopener noreferrer"`;

exports[`modules/createDOMProps includes base reset style for browser-styled elements 1`] = `"css-reset-4rbku5"`;

Expand Down
10 changes: 10 additions & 0 deletions packages/react-native-web/src/modules/createDOMProps/__tests__/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,16 @@ describe('modules/createDOMProps', () => {
expect(props.rel).toMatchSnapshot();
});

test('allow explicit rel="opener" for "a" elements', () => {
const props = createDOMProps('a', { target: '_blank', rel: 'opener' });
expect(props.rel).toEqual('opener');
});

test('don\'t duplicate "rel" values for "a" elements', () => {
const props = createDOMProps('a', { target: '_blank', rel: 'noopener' });
expect(props.rel).toEqual('noopener noreferrer');
});

test('includes cursor style for pressable roles', () => {
expect(createDOMProps('span', { accessibilityRole: 'link' }).className).toMatchSnapshot();
expect(createDOMProps('span', { accessibilityRole: 'button' }).className).toMatchSnapshot();
Expand Down
12 changes: 10 additions & 2 deletions packages/react-native-web/src/modules/createDOMProps/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,16 @@ const createDOMProps = (component, props, styleResolver) => {
// https://mathiasbynens.github.io/rel-noopener/
// Note: using "noreferrer" doesn't impact referrer tracking for https
// transfers (i.e., from https to https).
if (component === 'a' && domProps.target === '_blank') {
domProps.rel = `${domProps.rel || ''} noopener noreferrer`;
// Note: Specifying rel="opener" will explicitly bypass this safeguard.
if (component === 'a' && domProps.target === '_blank' && domProps.rel !== 'opener') {
const relList = domProps.rel ? domProps.rel.split(' ') : [];
if (relList.indexOf('noopener') === -1) {
relList.push('noopener');
}
if (relList.indexOf('noreferrer') === -1) {
relList.push('noreferrer');
}
domProps.rel = relList.join(' ');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@necolas, how's this? We have only one array allocation now. Want me to keep it in pure string land?

}
// Automated test IDs
if (testID && testID.constructor === String) {
Expand Down