Add support for Carbon UI #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you remove the style changes |
|
Why? |
|
Your PR does 3 different, unrelated things. I'd rather review and merge single-purpose PRs with explanations. I'm currently iterating on the ways styles are handled in the library and I don't know what your changes are for |
|
Sure np, will tomorrow. |
|
I added Linking support in dc54e03 |
|
And ScrollView event normalization in 4c46126 (was needed for the ListView branch too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for compatibility with Carbon UI.
onLayoutworked great :)Stylesheet.create()to using classnameonScrollevent (added nativeEvent)Test Plan
Biggest change was moving from
Stylesheet.create()to classname. Reviewed the jest snapshot differences and updated them.