-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Carbon UI #282
Conversation
Please can you remove the style changes |
Why? |
Your PR does 3 different, unrelated things. I'd rather review and merge single-purpose PRs with explanations. I'm currently iterating on the ways styles are handled in the library and I don't know what your changes are for |
Sure np, will tomorrow. |
I added Linking support in dc54e03 |
And ScrollView event normalization in 4c46126 (was needed for the ListView branch too) |
This is for compatibility with Carbon UI.
onLayout
worked great :)Stylesheet.create()
to using classnameonScroll
event (added nativeEvent)Test Plan
Biggest change was moving from
Stylesheet.create()
to classname. Reviewed the jest snapshot differences and updated them.